From 35e7d66e8b114d49b4641f94baa1c812a52e0132 Mon Sep 17 00:00:00 2001 From: Skarn Date: Wed, 21 Oct 2020 10:19:10 +0300 Subject: [PATCH] fix going into an endless for loop for minimap processing --- src/noggit/MapView.cpp | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/noggit/MapView.cpp b/src/noggit/MapView.cpp index a76a6f53..2949e887 100644 --- a/src/noggit/MapView.cpp +++ b/src/noggit/MapView.cpp @@ -1563,20 +1563,19 @@ void MapView::saveMinimap(noggit::MinimapRenderSettings* settings) case noggit::MinimapGenMode::MAP: { // increment tile indices here - if (mmap_render_success) - { - mmap_render_index++; - } - tile_index tile = tile_index(mmap_render_index / 64, mmap_render_index % 64); if (_world->mapIndex.hasTile(tile)) { mmap_render_success = _world->saveMinimap(512, 512, tile); + + if (mmap_render_success) + { + mmap_render_index++; + } } else - { - do + {do { mmap_render_index++; tile.x = mmap_render_index / 64; @@ -1584,11 +1583,6 @@ void MapView::saveMinimap(noggit::MinimapRenderSettings* settings) } while (!_world->mapIndex.hasTile(tile) && mmap_render_index != 4095 ); - if (mmap_render_success) - { - mmap_render_index--; - } - } if (mmap_render_success && mmap_render_index >= 4095)